WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Remaining ia64 differences in xen driver code -- privcmd

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] Remaining ia64 differences in xen driver code -- privcmd
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Fri, 4 Nov 2005 13:12:29 -0600
Cc: "Magenheimer, Dan \(HP Labs Fort Collins\)" <dan.magenheimer@xxxxxx>
Delivery-date: Fri, 04 Nov 2005 19:13:35 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <516F50407E01324991DD6D07B0531AD57E7CB9@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <516F50407E01324991DD6D07B0531AD57E7CB9@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.8.2
On Friday 04 November 2005 11:31, Magenheimer, Dan (HP Labs Fort Collins) 
wrote:
> ...I'd like to move the remaining handful of ia64 differences
> into the mainline using "#ifdef __ia64__".  Would that
> be OK?  If so, I will include them in the next ia64 pull.
> If not, I'd appreciate some help with the x86 code changes.

I have also had to hack up privcmd.c for PowerPC. (It's not at all "done", but 
if you're curious you can see 
http://xenbits.xensource.com/ext/linux-ppc-2.6.hg?cmd=file;filenode=2d94a3add83d64fa65e574dffbcb9a7cebea5c4b;file=drivers/xen/privcmd/privcmd.c
 .) 

It would be cleaner to have privcmd_ioctl just call out to arch_privcmd_ioctl. 
For example, PPC Linux doesn't do physical<->machine translation right now. 
We will probably change that in the future, but for the moment things like 
'machine_to_phys_mapping' do not exist. It seems from your ifdefs that IA64 
has similar issues, so for now it seems there are more differences than 
commonality in privcmd_ioctl, so we should just make it arch-specific.

-- 
Hollis Blanchard
IBM Linux Technology Center

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>