[Xen-devel] Re: new gnttab_end_foreign_access?

To:	xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] Re: new gnttab_end_foreign_access?
From:	NAHieu <nahieu@xxxxxxxxx>
Date:	Thu, 3 Nov 2005 14:11:39 +0900
Delivery-date:	Thu, 03 Nov 2005 05:08:48 +0000
Domainkey-signature:	a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=BNzp3hsp+GAGMdDYJ8XiRprFR4gWdMBp7fQoImJWUtir2y7v4IiuWfyWJp5M5eGqg7iD/giAe80SVdhnfSC+0KE6QfLJbvA46G6Nq1m7pmTL2gvVNlKynS2PE/HTij8nbnBKmfJOsAJNzDcUgvCI+HcKO9Tx1t+wPOrIuxJfIOg=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<5d7aca950511022051g311a8411o4d8e5d383385aee0@xxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<5d7aca950511022036q7b710539gff3b5bc2c8861b23@xxxxxxxxxxxxxx> <5d7aca950511022051g311a8411o4d8e5d383385aee0@xxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 11/3/05, NAHieu <nahieu@xxxxxxxxx> wrote:
> I have one more question:why gnttab_end_foreign_access_ref(grant_ref_t
> ref, int readonly) needs the "readonly" arg?
>
> Is gnttab_end_foreign_access_ref(grant_ref_t ref) not OK?
>


I took another look, and it seems we should remove "readonly" arg of
gnttab_end_foreign_access*, as they are not in use.

So those  API should be:

int gnttab_end_foreign_access_ref(grant_ref_t ref);
void gnttab_end_foreign_access(grant_ref_t ref, unsigned long page);


I still have some doubt about the "page" arg, however.

Thanks
Hieu

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] Re: new gnttab_end_foreign_access?