 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] misleading names in xen memory management code
| To: | "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] misleading names in xen memory management code |
| From: | "Li, Xin B" <xin.b.li@xxxxxxxxx> |
| Date: | Sat, 29 Oct 2005 10:03:19 +0800 |
| Delivery-date: | Sat, 29 Oct 2005 02:01:22 +0000 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcXcLO8xmuQY6DAYQpmS7aG4WO2Z4g== |
| Thread-topic: | misleading names in xen memory management code |
Keir, I think we have some misleading names in xen memory management
code:
1) #define page_to_pfn(_page) ((unsigned long)((_page) - frame_table))
Actually, it should be page_to_mfn.
2) #define l1e_from_pfn(pfn, flags) \
((l1_pgentry_t) { ((intpte_t)(pfn) << PAGE_SHIFT) |
put_pte_flags(flags) })
Seems l1e_from_mfn(mfn, flags) is much more clear.
Am I right?
-Xin
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH] Add Initial Man Pages for xm and xmdomain.cfg, Daniel Stekloff |
|---|---|
| Next by Date: | RE: [Xen-devel] misleading names in xen memory management code, Ian Pratt |
| Previous by Thread: | [Xen-devel] [PATCH] Add Initial Man Pages for xm and xmdomain.cfg, Daniel Stekloff |
| Next by Thread: | RE: [Xen-devel] misleading names in xen memory management code, Ian Pratt |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
