WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 0/2] Change xs_read_watch interfaces to support v

To: Anthony Liguori <aliguori@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0/2] Change xs_read_watch interfaces to support variable arguments
From: Anthony Liguori <aliguori@xxxxxxxxxx>
Date: Mon, 03 Oct 2005 23:48:17 -0500
Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Christian Limpach <Christian.Limpach@xxxxxxxxxxxx>
Delivery-date: Tue, 04 Oct 2005 04:45:56 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4342087F.5010505@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4342087F.5010505@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.6 (X11/20050912)
I should mention that I ran the xenstore testsuite (which rocks btw) and tested the block devices and network devices. I haven't tested blktap and vtpm but the changes are identical (and I don't have any test cases for those).

Regards,

Anthony Liguori

Anthony Liguori wrote:

The following set of changes modify the read_watch interface in userspace and in the kernel to support variable arguments. This is in preparation for adding domid to @{introduce,release}Domain watches. This will allow backends to automatically reap on domain destruction which should eliminate a large number of the zombie problems we're having on domain destruction since Xend no longer plays a role in freeing that memory.

The interface for read_watch is now consistent between userspace and kernel space. It's modelled after xs_read_directory. The returned array is indexable via XS_WATCH_* macros.

While slightly awkward, IMHO it seems like the cleanest and most flexible option of the proposed interfaces.

Signed-off-by: Anthony Liguori <aliguori@xxxxxxxxxx>

Regards,

Anthony Liguori

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel