WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] fix the control panel problem for latest tree

To: Xiaofeng Ling <xiaofeng.ling@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix the control panel problem for latest tree
From: Christian Limpach <Christian.Limpach@xxxxxxxxxxxx>
Date: Tue, 20 Sep 2005 10:44:11 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 20 Sep 2005 09:41:53 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <432F95E2.9060505@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <3ACA40606221794F80A5670F0AF15F84098454E1@pdsmsx403> <3d8eece205091611511f17b6e1@xxxxxxxxxxxxxx> <432F95E2.9060505@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.1i
Thanks!

On Tue, Sep 20, 2005 at 12:53:54PM +0800, Xiaofeng Ling wrote:
> Attach is patch to fix the problem when using vnc instead of SDL.
> Because new image handling structure move configurtion to image
> handle creating, at that time, the domain struct is not created yet,
> so vnc code can not get domid.
> In this patch, I split the image configuration into two parts.
> maybe not so ideal, but just simple.
> 
> Christian Limpach wrote:
> >Thanks!
> >
> >On 9/16/05, Ling, Xiaofeng <xiaofeng.ling@xxxxxxxxx> wrote:
> >
> >>The new image handling structure break the vmx guest loading, this patch
> >>fix it.
> >>
> >>Signed-off-by: Xiaofeng Ling <xiaofeng.ling@xxxxxxxxx>
> >>
> >>diff -r fe916b4a7d74 -r 089ec1b6817c tools/python/xen/xend/image.py
> >>--- a/tools/python/xen/xend/image.py    Fri Sep 16 02:53:39 2005
> >>+++ b/tools/python/xen/xend/image.py    Fri Sep 16 06:30:21 2005
> >>@@ -271,9 +271,10 @@
> >>   def configure(self, config):
> >>       ImageHandler.configure(self, config)
> >>       if not config:
> >>-            self.memmap, self.dmargs, self.device_model, self.display = 
> >>self.vm.gatherVm(
> >>+            self.memmap, dmargs, self.device_model, self.display = 
> >>self.vm.gatherVm(
> >>               ("image/memmap"), ("image/dmargs"), ("image/device-model"),
> >>               ("image/display"))
> >>+            self.dmargs = dmargs.split(' ')
> >>           return
> >>
> >>       self.memmap = sxp.child_value(config, 'memmap')
> >>@@ -283,10 +284,10 @@
> >>           raise VmError("vmx: missing device model")
> >>       self.display = sxp.child_value(config, 'display')
> >>
> >>-        self.storeVm(("image/memmap", self.memmap),
> >>-                     ("image/dmargs", self.dmargs),
> >>-                     ("image/device-model", self.device_model),
> >>-                     ("image/display", self.display))
> >>+        self.vm.storeVm(("image/memmap", self.memmap),
> >>+                        ("image/dmargs", " ".join(self.dmargs)),
> >>+                        ("image/device-model", self.device_model),
> >>+                        ("image/display", self.display))
> >>
> >>   def createImage(self):
> >>       """Create a VM for the VMX environment.
> >>@@ -346,7 +347,7 @@
> >>               ret.append("%s" % v)
> >>
> >>       # Handle disk/network related options
> >>-        devices = sxp.children(config, 'device')
> >>+        devices = sxp.children(self.vm.config, 'device')
> >>       for device in devices:
> >>           name = sxp.name(sxp.child0(device))
> >>           if name == 'vbd':
> >>
> >>
> >>_______________________________________________
> >>Xen-devel mailing list
> >>Xen-devel@xxxxxxxxxxxxxxxxxxx
> >>http://lists.xensource.com/xen-devel
> >>
> >>
> >>
> >>
> >
> >
> >_______________________________________________
> >Xen-devel mailing list
> >Xen-devel@xxxxxxxxxxxxxxxxxxx
> >http://lists.xensource.com/xen-devel
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>