Re: [Xen-devel] [PATCH][VT] Patch to allow VMX domainsto be destroyedor shut down cleanly

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 19 Sep 2005, at 18:26, Khoa Huynh wrote:

> If the shadow page reference counts are handled correctly now (I look
> forward to receiving a complete patch!), do we really need
> shadow_tainted_refcnts flag in the domain structure ?  What's
> the real purpose of this flag ?  Is it used to indicate that
> shadow mode was enabled but now disabled ?
Although the general ref counts are okay, I think the type counts can 
be wrong. Certainly the only use of tainted_refcnts check is to avoid 
an assertion in common/page_alloc.c (it asserts that if the general 
count is zero, teh type count must also be zero).
Do a debug build of Xen, remove the tainted_refcnts check from 
page_alloc.c, and see if destroying a vmx domain kills Xen. :-)
If not, maybe we can remove that flag.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel