WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Fix blatant non-archdep'isms... need help with build env

To: "Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>
Subject: Re: [Xen-devel] Fix blatant non-archdep'isms... need help with build env change?
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 13 Sep 2005 11:32:47 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 13 Sep 2005 10:25:50 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <516F50407E01324991DD6D07B0531AD5695A20@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <516F50407E01324991DD6D07B0531AD5695A20@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 13 Sep 2005, at 00:25, Magenheimer, Dan (HP Labs Fort Collins) wrote:

If someone more experienced with the build
environment can add an "asm" link (such as
the one created by linux for include/asm),
I would be happy to provide a patch for the
actual changes.

There's already a symlink include/asm-xen/asm pointing to the appropriate arch-specific subdir under asm-xen. Or do you mean something else?

The problem files (in sparse/include/asm-xen):

- synch_bitops.h: explicitly includes
  asm-i386/synch_bitops.h, should include
  <asm-xen/asm/synch_bitops.h>

I can fix this one easily enough.

- hypervisor.h: about half of this header is
  generic and half is x86-specific.  Should
  include <asm-xen/asm/hypervisor.h> for
  arch-dep code.

Approximately none of it looks arch-independent. I'd be happy to move the whole lot to asm-xen/asm-i386 and link across to asm-xen/asm-x86_64. Unless you think more than a handful of lines could be kept as arch-independent code?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>