 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH][VT] No DISALLOW pte bit check for VMX domain
| To: | "Li, Chengyuan" <chengyuan.li@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH][VT] No DISALLOW pte bit check for VMX domain |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Mon, 12 Sep 2005 11:06:25 +0100 |
| Cc: | xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Mon, 12 Sep 2005 09:59:30 +0000 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <59D45D057E9702469E5775CBB56411F165A0E9@pdsmsx406> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <59D45D057E9702469E5775CBB56411F165A0E9@pdsmsx406> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On 12 Sep 2005, at 08:05, Li, Chengyuan wrote: Hi, VMX domain don't need DISALLOW pte bit checking. Signed-off-by: Chengyuan Li <chengyuan.li@xxxxxxxxx> I think they do need these checks. get_page_from_l1e() is only called on real pagetables, even in shadow mode (i.e., it is called for the shadow pte's). We still want to check that the guest isn't trying to set weird PAT values or, if it is, we need to deal with those explicitly. For now, I think the correct think to do is to apply L1_DISALLOW_MASK before calling get_page_from_l1e(). You already strip off the GLOBAL bit, but the rest should be stripped also. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH][VT] No DISALLOW pte bit check for VMX domain, Li, Chengyuan |
|---|---|
| Next by Date: | [Xen-devel] [PATCH][VT] Clear the pending interrupt on shared page when PIC initialized, Jiang, Yunhong |
| Previous by Thread: | [Xen-devel] [PATCH][VT] No DISALLOW pte bit check for VMX domain, Li, Chengyuan |
| Next by Thread: | RE: [Xen-devel] [PATCH][VT] No DISALLOW pte bit check for VMX domain, Li, Chengyuan |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
