 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] get xenstore buffer in vmx guest
| To: | Xiaofeng Ling <xiaofeng.ling@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] get xenstore buffer in vmx guest |
| From: | Rusty Russell <rusty@xxxxxxxxxxxxxxx> |
| Date: | Mon, 05 Sep 2005 21:14:53 +1000 |
| Cc: | Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Mon, 05 Sep 2005 11:12:54 +0000 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <431C03FC.1060302@xxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <431C03FC.1060302@xxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Mon, 2005-09-05 at 16:38 +0800, Xiaofeng Ling wrote:
> static inline struct ringbuf_head *outbuf(void)
> {
> - return mfn_to_virt(xen_start_info.store_mfn);
> + return XENSTORE_BUF;
> }
Just a minor thing: I'd really prefer an inline function called
xenstore_page_virt() or something, rather than a macro which looks like
a constant.
Thanks!
Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] RE: [PATCH][1/6] add a hypercall number for virtual device in unmodified guest, Ian Pratt |
|---|---|
| Next by Date: | Re: [Xen-users] xen 2.0.7 on VIA C3 (EPIA), Rafael Ferreira |
| Previous by Thread: | [Xen-devel] [PATCH] get xenstore buffer in vmx guest, Xiaofeng Ling |
| Next by Thread: | RE: [Xen-devel] [PATCH] get xenstore buffer in vmx guest, Ling, Xiaofeng |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
