WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH][VT]value is not needed for some device model paramte

To: Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH][VT]value is not needed for some device model paramters
From: Xiaofeng Ling <xiaofeng.ling@xxxxxxxxx>
Date: Mon, 05 Sep 2005 12:13:41 +0800
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 05 Sep 2005 04:14:39 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510
for device mode parameter:std-vga, localtime, isa, value is not needed.

Signed-off-by: Xiaofeng Ling <xiaofeng.ling@xxxxxxxxx>
Signed-off-by: Arun Sharma <arun.sharma@xxxxxxxxx>

diff -r 2be69124cb06 -r c5ba8748d09c tools/python/xen/xend/image.py
--- a/tools/python/xen/xend/image.py    Mon Sep  5 03:56:13 2005
+++ b/tools/python/xen/xend/image.py    Mon Sep  5 03:56:22 2005
@@ -338,12 +338,16 @@

             # Handle booleans gracefully
             if a in ['localtime', 'std-vga', 'isa']:
-                if v != None: v = int(v)
-
-           log.debug("args: %s, val: %s" % (a,v))
-           if v:
-               ret.append("-%s" % a)
-               ret.append("%s" % v)
+                if v != None:
+                    v = int(v)
+                if v:
+                    ret.append("-%s" % a)
+            else:
+                if v:
+                    ret.append("-%s" % a)
+                    ret.append("%s" % v)
+            log.debug("args: %s, val: %s" % (a,v))
+

         # Handle disk/network related options
         devices = sxp.children(self.vm.config, 'device')

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH][VT]value is not needed for some device model paramters, Xiaofeng Ling <=