This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] Xenstore testsuite robustness: save output rather th

To: Xen Mailing List <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] Xenstore testsuite robustness: save output rather than rerun on failure.
From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Date: Sun, 21 Aug 2005 17:10:05 +1000
Delivery-date: Sun, 21 Aug 2005 22:22:24 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
"make check" reruns a test which fails with more verbosity.  If the test
fails intermittently, that doesn't work well: save the output and simply
dump it if the test fails.

Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

# HG changeset patch
# User Rusty Russell <rusty@xxxxxxxxxxxxxxx>
# Node ID 07b986fec159c8bd18f7f109ca78c5b1250ee07c
# Parent  68ace2715cbc988c27c494a44a3154dbfcf83d0e
Rather than re-run on failure, record and replay (needed for occasional 

diff -r 68ace2715cbc -r 07b986fec159 tools/xenstore/testsuite/test.sh
--- a/tools/xenstore/testsuite/test.sh  Sat Aug 20 05:53:26 2005
+++ b/tools/xenstore/testsuite/test.sh  Sun Aug 21 06:29:47 2005
@@ -52,11 +52,10 @@
     case `basename $f` in $MATCH) RUN=1;; esac
     [ -n "$RUN" ] || continue
-    if run_test $f > /dev/null; then
+    if run_test $f -x >/tmp/out; then
        echo -n .
-       echo Test $f failed, running verbosely...
-       run_test $f -x || true
+       cat /tmp/out
        # That will have filled the screen, repeat message.
        echo Test $f failed
        exit 1

A bad analogy is like a leaky screwdriver -- Richard Braakman

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>