This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH] [x86_64] Fixing PGT_va_mutable and PGT_va_unknow

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] [x86_64] Fixing PGT_va_mutable and PGT_va_unknown
From: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
Date: Mon, 15 Aug 2005 01:06:31 -0700
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 15 Aug 2005 08:04:54 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcWhbo21tppUoZgYRBKZfHp0PmlgnQAAY7Fw
Thread-topic: [Xen-devel] [PATCH] [x86_64] Fixing PGT_va_mutable and PGT_va_unknown
Keir Fraser wrote:
> On 15 Aug 2005, at 08:50, Nakajima, Jun wrote:
>>> Okay, but I see no reason to change PGT_va_mask. You already include
>>> 28 bits where you actually need only 27 bits of backptr.
>> The current one
>> #define PGT_va_mask         ((unsigned
>> long)((1U<<28)-1)<<PGT_va_shift) includes only 27 bits (see -1).
> (1<<n)-1 sets the n least significant bits, not n-1.
You are right. I need to go to bed now. 

>   -- Keir

Intel Open Source Technology Center

Xen-devel mailing list