WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] Fix xm block-destroy

To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] Fix xm block-destroy
From: Anthony Liguori <aliguori@xxxxxxxxxx>
Date: Fri, 12 Aug 2005 15:00:53 -0500
Delivery-date: Fri, 12 Aug 2005 19:59:37 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.2 (X11/20050317)
If block-create didn't work, then chances are block-destroy doesn't work either right :-)

In this case, XendDomain.py is just calling a function that doesn't exist (device_destroy instead of device_delete).

Regards,

Anthony Liguori

Signed-off-by: Anthony Liguori <aliguori@xxxxxxxxxx>
# HG changeset patch
# User Anthony Liguori <aliguori@xxxxxxxxxx>
# Node ID 73fccd848200b63230002b2d96df897ab232627a
# Parent  17e1b03d6932fa4eb827d61fd7cb32c04213e421
Types do matter in dictionaries, this fixes xm block-destroy

diff -r 17e1b03d6932 -r 73fccd848200 tools/python/xen/xend/server/controller.py
--- a/tools/python/xen/xend/server/controller.py        Fri Aug 12 19:34:09 2005
+++ b/tools/python/xen/xend/server/controller.py        Fri Aug 12 20:06:15 2005
@@ -325,7 +325,7 @@
         return self.destroyed
 
     def getDevice(self, id, error=False):
-        dev = self.devices.get(id)
+        dev = self.devices.get(int(id))
         if error and not dev:
             raise XendError("invalid device id: " + str(id))
         return dev
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] Fix xm block-destroy, Anthony Liguori <=