 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] [PATCH] code tidyness xen/tools/symbol.c
| To: | xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] [PATCH] code tidyness xen/tools/symbol.c |
| From: | Jerone Young <jyoung5@xxxxxxxxxx> |
| Date: | Thu, 11 Aug 2005 10:56:42 -0500 |
| Delivery-date: | Thu, 11 Aug 2005 15:57:25 +0000 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Fix where "!" operator used in Bitwise operation.
In IBM we have an internal source code scanner called BEAM. We have run
it against Xen and here are some of the results.
Signed-off-by: Jerone Young <jyoung5@xxxxxxxxxx>
--- xen/tools/symbols.c.old 2005-08-11 07:42:27.000000000 -0500
+++ xen/tools/symbols.c 2005-08-11 08:06:46.000000000 -0500
@@ -311,7 +311,7 @@ write_src(void)
off = 0;
for (i = 0; i < cnt; i++) {
- if (!table[i].flags & SYM_FLAG_VALID)
+ if (!(table[i].flags & SYM_FLAG_VALID))
continue;
if ((valid & 0xFF) == 0)
--
Jerone Young
IBM Linux Technology Center
jyoung5@xxxxxxxxxx
512-838-1157 (T/L: 678-1157)
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] code question?, Jerone Young |
|---|---|
| Next by Date: | Re: [Xen-devel] Unknown interrupt on x86_64 Xen on ES7000 x86_64, Keir Fraser |
| Previous by Thread: | [Xen-devel] code question?, Jerone Young |
| Next by Thread: | [Xen-devel] [PATCH] xm reboot, aq |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
