| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] RE: [PATCH 1/2] Writable pagetable support for x86_64 xe
On 9 Aug 2005, at 08:59, Nakajima, Jun wrote:
One ugly code that I don't like is __not_mapped(l2_pgentry_t *pl2e).
Any
idea for doing it better?
I used a patch from Chris/Xin for the x86_64 SMP kernel. Probably he
has
more updates there.
i checked in a cleaned up version of your SMP patch, as part of some
wider-ranging cleanups of your previous wrpt patch. A couple of notes
on that:
1. I got rid of __not_mapped(). It should suffice to attempt the
access through the linear mapping and handle the possible fault.
2. You had gross CONFIG_X86_64-specific tests in get_page_type(). I
cannot see how any good could possible come of them so I removed them.
Either you need a good justification why they're needed or, if they
actually fixed observed problems, I think there must be some underlying
bug that those conditional sections of code were masking. Either way,
this needs looking at.
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home