This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix domain CPU time calculation to count all VCP

To: Josh Triplett <josht@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix domain CPU time calculation to count all VCPU times correctly
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 8 Aug 2005 19:37:28 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 08 Aug 2005 18:41:33 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1123525364.2881.13.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1123525364.2881.13.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 8 Aug 2005, at 19:22, Josh Triplett wrote:

This causes a VCPU's time to only be counted if it is greater than the
current total; so if VCPU0 has 10 seconds and VCPU1 has 5, the total
will be 10, but if VCPU0 has 5 and VCPU10 has 10, the total will be 15.
Is there a reason for this behavior? It seems more useful and intuitive
to always total the VCPU times to obtain the CPU time.

I think we used to return the highest VCPU time as domain time. Someone decided to instead sum across all VCPU times, but I guess forgot to remove the conditional. :-)

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>