This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] alloc_{start,end} truncation

To: "Scott Parish" <srparish@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] alloc_{start,end} truncation
From: Gerd Knorr <kraxel@xxxxxxx>
Date: 08 Aug 2005 14:56:02 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 08 Aug 2005 12:58:24 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20050805175257.GB12423@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: SUSE Labs, Berlin
References: <20050805175257.GB12423@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
"Scott Parish" <srparish@xxxxxxxxxx> writes:

> Alloc_{start,end} should be physaddr_t. See attached patch.

Ha, *that* the bug I was hunting as well ;)

> +++ new-xen-pae/xen/arch/x86/domain_build.c   2005-08-05 17:48:07.000000000 
> +0000

This change looks perfectly fine.

> --- old-xen-pae/xen/include/asm-x86/io.h      2005-07-19 18:51:39.000000000 
> +0000
> +++ new-xen-pae/xen/include/asm-x86/io.h      2005-08-05 17:45:17.000000000 
> +0000
> @@ -45,7 +45,7 @@ static inline void * phys_to_virt(unsign
>  /*
>   * Change "struct pfn_info" to physical address.
>   */

That one should be "CONFIG_X86_PAE"

>  #define page_to_phys(page)  ((u64)(page - frame_table) << PAGE_SHIFT)

But I think even better is to simply drop the ifdef and turn that into

"#define page_to_phys(page)  ((physaddr_t)(page - frame_table) << PAGE_SHIFT)"

With these changes in place the dom0 builder survives on my 6GB test
box, now the linux kernel seems to crash early at boot, continuing
debugging ...


panic("it works"); /* avoid being flooded with debug messages */

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>