This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] Remove priority arg from python interface

To: Xen Mailing List <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] Remove priority arg from python interface
From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Date: Fri, 05 Aug 2005 13:48:11 +1000
Delivery-date: Fri, 05 Aug 2005 03:46:35 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
The C interface no longer has a priority arg, but the python interface
still takes one (and just doesn't use it).  Noone uses it anyway, so
nothing should break by taking it away.

Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

diff -urpN --exclude=docs --exclude=dist --exclude TAGS -X 
/home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal 
--- xen-unstable.hg-mainline/tools/python/xen/lowlevel/xs/xs.c  2005-08-05 
13:01:03.000000000 +1000
+++ xen-unstable.hg-xenstored-update/tools/python/xen/lowlevel/xs/xs.c  
2005-08-05 13:05:14.000000000 +1000
@@ -343,7 +334,6 @@ static PyObject *xspy_set_permissions(Py
 #define xspy_watch_doc "\n"                                            \
        "Watch a path, get notifications when it changes.\n"            \
        " path     [string] : xenstore path.\n"                         \
-       " priority [int]    : watch priority (default 0).\n"            \
        " token    [string] : returned in watch notification.\n"        \
        "\n"                                                            \
        "Returns: [int] 0 on success.\n"                                \
@@ -352,10 +342,9 @@ static PyObject *xspy_set_permissions(Py
 static PyObject *xspy_watch(PyObject *self, PyObject *args, PyObject *kwds)
-    static char *kwd_spec[] = { "path", "priority", "token", NULL };
+    static char *kwd_spec[] = { "path", "token", NULL };
     static char *arg_spec = "s|is";
     char *path = NULL;
-    int priority = 0;
     char *token = "";
     struct xs_handle *xh = xshandle(self);
@@ -365,7 +354,7 @@ static PyObject *xspy_watch(PyObject *se
     if (!xh)
        goto exit;
     if (!PyArg_ParseTupleAndKeywords(args, kwds, arg_spec, kwd_spec, 
-                                     &path, &priority, &token))
+                                     &path, &token))
         goto exit;
     xsval = xs_watch(xh, path, token);
     val = pyvalue_int(xsval);

A bad analogy is like a leaky screwdriver -- Richard Braakman

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] Remove priority arg from python interface, Rusty Russell <=