Re: [Xen-devel] [PATCH] Make Xend use consoled and xc_console

[Anthony Liguori <aliguori@xxxxxxxxxx>]

Ian Pratt wrote:

> > The attached patch removes all of the console handling code 
> > from Xend and changes xm to simply exec /usr/libexec/xen/xc_console.
> >    
> Please can you provide some more detail, particularly how it changes
> things from a user point of view. How do you disconnect and reconnect to
> consoles? Does the '-c' option to xm still work? Can the user control
> allocation of are tty names?
>  
xm console still connects and disconnects to the console.

xm create -c still works as expected.

You still disconnect from the console with C-].  The only user facing 
difference is that xm list does not have a console field (the port it 
showed previously was meaningless anyway with domain sockets) and xm no 
longer supports the consoles command (since again, the information it 
was displaying wasn't all that useful).
If we export over tcp then we can add some info back into xm.  However, 
I'd much rather implement the NSS plugin we talked about at the Summit.
tty names are automatically chosen by the OS so there isn't really 
anything to control.
> Also, should consoled really line in /usr/sbin/ ?  I think it should be
> in /usr/lib/xen/bin
>  
I put it there since that's where we have xenstored installed.  We can 
certainly install it somewhere else though.
> (Didn't we decide /usr/libexec was deprecated anyhow?)
>  
If it is, I'll submit a patch to relocate the contents of /usr/libexec/xen.

> BTW: does this fix the console output corruption bug that's on the
> books?
>  
I've not been able to reproduce it.  I had 50 domains running all 
cat'ing /dev/urandom and I was able to input/output large amounts of 
data without corruption to another domain.
With that said though, I'm still not convinced it's fixed completely 
because I don't think xcs buffers everything correctly.  The new console 
drivers should do the trick though since we won't need to go through xcs.
Regards,

Anthony Liguori

> Thanks,
> Ian 
>
>  
>
> > I've done a pretty good amount of testing and this seems to 
> > clear up all of the Xend console issues in bugzilla.
> > This is a pretty big change to Xend though with a lot of 
> > deleted code so I'd appreciate if people more familiar with 
> > the Xend codebase could look through it critically.
> > In addition to the patch, the following files are no longer used:
> >
> > tools/python/xen/util/console_client.py
> > tools/python/xen/xend/XendConsole.py
> > tools/python/xen/xend/server/SrvConsole.py
> > tools/python/xen/xend/server/SrvConsoleDir.py
> > tools/python/xen/xend/server/console.py
> >
> > Regards,
> >
> > Anthony Liguori
> >
> > Signed-off-by: Anthony Liguori <aliguori@xxxxxxxxxx>
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xen-devel
> >
> >    
>  
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel