Re: [Xen-devel] [PATCH] A minor change to Makefile

Jiang, Yunhong wrote:
> -       [ -d $(D)/etc/xen ] && mv -f $(D)/etc/xen
> $(D)/etc/xen.old-$(date +%s)
> +       -[ -d $(D)/etc/xen ] && mv -f $(D)/etc/xen
> $(D)/etc/xen.old-$(shell date +%s)

Not the right change.  Use

[ -d $(D)/etc/xen ] && mv -f $(D)/etc/xen $(D)/etc/xen.old-$$(date +%s)


make needs the sub-shell command to be escaped (two $).

-- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖

signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] A minor change to Makefile, Jiang, Yunhong Re: [Xen-devel] [PATCH] A minor change to Makefile, Ulrich Drepper <=

Previous by Date:

Re: [Xen-devel] using domain0 file as root disk for domU, Paul Larson

Next by Date:

[Xen-devel] [PATCH] safely calculate page number from maxmem, aq

Previous by Thread:

[Xen-devel] [PATCH] A minor change to Makefile, Jiang, Yunhong

Next by Thread:

[Xen-devel] using domain0 file as root disk for domU, Magenheimer, Dan (HP Labs Fort Collins)

Indexes:

[Date] [Thread] [Top] [All Lists]