WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [Xen-changelog] This adds a patch for the vanilla ke

To: Rik van Riel <riel@xxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [Xen-changelog] This adds a patch for the vanilla kernel, to be pushed upstream some
From: Gerd Knorr <kraxel@xxxxxxx>
Date: 13 Jul 2005 09:55:45 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 13 Jul 2005 07:58:46 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <Pine.LNX.4.61.0507121144050.1271@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: SUSE Labs, Berlin
References: <E1Ds0Vu-0004aO-Bd@xxxxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.61.0507121144050.1271@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
Rik van Riel <riel@xxxxxxxxxx> writes:

> On Mon, 11 Jul 2005, Xen patchbot -unstable wrote:
> 
> > --- a/linux-2.6-xen-sparse/arch/xen/i386/mm/pgtable.c       Mon Jul 11 
> > 15:43:12 2005
> > +++ b/linux-2.6-xen-sparse/arch/xen/i386/mm/pgtable.c       Mon Jul 11 
> > 15:46:46 2005
> 
> >     if (PTRS_PER_PMD == 1 || !pgd)
> >             return pgd;
> >  
> > +   if (!HAVE_SHARED_KERNEL_PMD) {
> > +           /* alloc and copy kernel pmd */
> > +           unsigned long flags;
> > +           pgd_t *copy_pgd = pgd_offset_k(PAGE_OFFSET);
> > +           pud_t *copy_pud = pud_offset(copy_pgd, PAGE_OFFSET);
> 
> I don't understand how the code inside this if condition
> ever gets to run.  Surely the previous test should catch
> the non-PAE case already ?

It's about PAE mode.  xenlinux in PAE mode does _not_ have a shared
PMD for the kernel address space.

  Gerd

-- 
panic("it works"); /* avoid being flooded with debug messages */

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel