 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] xc_ptrace.c fix
| To: | Kip Macy <kip.macy@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] xc_ptrace.c fix |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Sun, 3 Jul 2005 09:30:51 +0100 |
| Cc: | xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Sun, 03 Jul 2005 08:34:30 +0000 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <b1fa291705070218077e176e28@xxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <b1fa291705070218077e176e28@xxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On 3 Jul 2005, at 02:07, Kip Macy wrote: Could you please apply the following trivial patch (yes I know, gmail screws up whitespace). It fixes a crash in the gdbserver that can be hit when debugging linux. But you set pde_virt immediately above the test that you are patching, if pde_phys[cpu] != pde. And if mmap'ing pde_virt fails, you bail with an error. So how can you get pde_virt[cpu] == NULL at that point -- aren;t you just hiding the real bug? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] xm info, aq |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] xm info, Keir Fraser |
| Previous by Thread: | [Xen-devel] [PATCH] xc_ptrace.c fix, Kip Macy |
| Next by Thread: | [Xen-devel] Recurring OOPS in latest -unstable kernel, Kip Macy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
