WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] more xenstore makefile fixes

To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] more xenstore makefile fixes
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Thu, 16 Jun 2005 10:59:29 -0500
Delivery-date: Thu, 16 Jun 2005 16:00:29 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1118343285.20524.20.camel@thinkpad>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <1118343285.20524.20.camel@thinkpad>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2005-06-09 at 13:54 -0500, Jerone Young wrote:
> This allows tools in the python directory to properly link to
> libxenstore.a on x86-64.
> --- tools/xenstore/Makefile.orig        2005-06-09 12:56:34.000000000
> -0500
> +++ tools/xenstore/Makefile     2005-06-09 13:48:06.000000000 -0500
> @@ -20,6 +20,9 @@
>  BASECFLAGS+= -I.
> 
>  CFLAGS+=$(BASECFLAGS)
> +ifeq ($(XEN_TARGET_ARCH),x86_64)
> +CFLAGS += -fPIC
> +endif
>  LDFLAGS=$(PROFILE) -L$(XEN_LIBXC)
>  TESTDIR=`pwd`/testsuite/tmp
>  TESTFLAGS=-DTESTING

Position Independent Code (PIC) is needed for shared libraries on all
architectures. This has come up before, on this list even:
http://lists.xensource.com/archives/html/xen-devel/2005-02/msg00241.html

I don't expect xenstore would be very performance-critical...

--- 1.4/tools/xenstore/Makefile 2005-06-10 03:42:25 -05:00
+++ edited/Makefile     2005-06-16 10:00:53 -05:00
@@ -20,9 +20,7 @@
 BASECFLAGS+= -I.

 CFLAGS += $(BASECFLAGS)
-ifeq ($(XEN_TARGET_ARCH),x86_64)
 CFLAGS += -fPIC
-endif
 LDFLAGS=$(PROFILE) -L$(XEN_LIBXC)
 TESTDIR=`pwd`/testsuite/tmp
 TESTFLAGS=-DTESTING

Signed-off-by: Hollis Blanchard

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>