Re: [Xen-devel] [PATCH] Fixing iopl and ioperm

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 11 Jun 2005, at 06:45, Nakajima, Jun wrote:

> With this patch, x86 and x86-64 share ioport.c, fixing LTP iopl and
> ioperm testcase failures (on both). We found an iopl testcase failing
> even on x86 xenlinux.
>
> Now x86-64 xenlinux should have the same results regarding the LTP
> testcases (as far as we tested).
Why does this patch modify the i386 ioport.c so much? I would expect 
that you ought to be able to use the xen/i386 ioport.c with no 
modification at all. The different function prototypes for sys_iopl 
between i386 and x86_64 shouldn't matter -- x86_64 ought to work with 
teh existing xen/i386 function prototype and function implementation.
The patch you sent is broken in any case -- you cannot find the old 
iopl by looking at eflags, as the real iopl is always zero.
Please re-send with the *smallest possible* changes to 
xen/i386/kernel/ioport.c. If there are justifiable 
cleanups/simplifications, then I'd like to take those as a separate 
patch!
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel