RE: [Xen-devel] [patch] nx bit shouldn't get set when disabled

["Nakajima, Jun" <jun.nakajima@xxxxxxxxx>]

Scott Parish wrote:
> On Wed, Jun 08, 2005 at 10:23:47PM +0100, Keir Fraser wrote:
> 
>> I'm not inclined to take patches for xen/x86_64/pci-dma.c anyway: I
>> think we can patch the xen/i386 one and share it with xen/x86_64.
>> Otherwise we're going to get unnecessary divergence between what
>> really ought to be two identical files. (I already did this for
>> arch/xen/i386/kernel/time.c, for example.)
> 
> The attached patch unifies pci-dma.c and adds the pte_mfn() macro.
> 
> The one thing that might need an explanation, there's 4 lines of
> changes (walking the page table) that add parentheses. The x86_64
> compiler doesn't seem to like doing unparenthesized math for function
> arguments. 
> 
> Boot tested dom0 on x86_64 and x86_32 (non-pae)
> 
> sRp

Looks good. That's the right thing.

BTW, I thought I found a bug in phys_pud_init(), but it's not.

Jun
---
Intel Open Source Technology Center

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel