Re: [Xen-devel] [PATCH] reiserfs module for pygrub

[aq <aquynh@xxxxxxxxx>]

On 5/24/05, Jeremy Katz <katzj@xxxxxxxxxx> wrote:
> On Wed, 2005-05-18 at 20:37 +0100, Ian Pratt wrote:
> > > here is a patch to add reiserfs (version 2,3) support to
> > > pygrub in -unstable (against cset 1.1434)
> >
> > Does Fedora have a reiserfs tools devel package?
> 
> Not at present.
> 
> > Please can you add something to the tools/check directory that checks
> > the appropriate headers are installed.
> 
> What if we check instead for the headers being present and only building
> the filesystem modules that there's support for on the system?  Then
> distributors can ensure they have the right things in their buildsystem
> and anyone else can do the same.  The attached patch should implement
> that for libext2fs.
> 
> > Also, at runtime, are there
> > issues with libraries being present? Can you load the library
> > dynamically if required?
> 
> The libraries get linked dynamically into the python module.  If at
> runtime, the library isn't present, it won't cause a fatal error (you
> won't be able to access those types of filesystems, but it won't fall
> over on the import)
> 

yes, this trick could be easily adapted to reiserfs and others. but
what if the user keeps the needed libraries, but removes those headers
( like /usr/include/ext2fs/ext2_fs.h )after building (for example to
make the system more compact)? then the check would fail.

actually we should check for those need to present at runtime, not
things at compile time. i propose checking /usr/lib/libext2fs.so
instead of header files (incase we use dynamic libs)

regards,
aq

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel