Re: [Xen-devel] [PATCH] vmx-gdbserver-sstep.patch

[David Hopwood <david.nospam.hopwood@xxxxxxxxxxxxxxxx>]

Arun Sharma wrote:
> +static inline int __vm_set_bit(unsigned long field, unsigned long mask)
> +{
> +        unsigned long tmp;
> +        int err = 0;
> +
> +        err |= __vmread(field, &tmp);
> +        tmp |= mask;
> +        err |= __vmwrite(field, tmp);
Wouldn't this be better:

  err = __vmread(field, &tmp);
  tmp |= mask;
  if (err == 0) err = __vmwrite(field, tmp);

(and similarly for __vm_clear_bit)?

--
David Hopwood <david.nospam.hopwood@xxxxxxxxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel