WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] Fixing stack alignment in x86-64 Xen

To: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] Fixing stack alignment in x86-64 Xen
From: Andi Kleen <ak@xxxxxx>
Date: 18 May 2005 18:14:11 +0200
Date: Wed, 18 May 2005 18:14:11 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 18 May 2005 16:13:38 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <7F740D512C7C1046AB53446D3720017304021E83@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <7F740D512C7C1046AB53446D3720017304021E83@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.1i
> I think the right thing is to get rsp0 in TSS on a 16-byte boundary by
> getting get_stack_bottom() and get_cpu_user_regs() see the correct
> stack. That will fix the reset_stack_and_jump() as well. It's basically
> what my patch does. 

This means you cannot disable the 16 byte stack alignment in gcc.
Probably does not matter too much today (I guess Xen is not that
bad a stack pig), but in the far future it might come in useful.
Also it would generate smaller code.

-Andi

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel