Re: [Xen-devel] [PATCH] remove tabs from xm/main.py

[aq <aquynh@xxxxxxxxx>]

On 5/18/05, Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx> wrote:
> > while investigating xm/main.py, i found that it is mixed with
> > tabs and whitespaces. that is annoying and may get us
> > misleaded when reading code. looks like that the conventional
> > coding style of Python (and also C?) in Xen is to use (4)
> > whitespaces instead of tabs? could anybody confirm this?
> >
> > i searched in all tree and found bunch of files like this. if
> > nobody complains, i will catch them all (both C and Python
> > codes) and send in
> > 1 patch to the list. any idea?
> >
> > this patch replace tab with 4 whitespaces in (only) xm/main.py
> 
> Particularly for python, this kind of patch can be *really* dangerous.
> Please can you confirm that you fully understand the python indentation
> rules (I don't), and that the patch was generated mechanically by a
> script.

yes, indentation for C codes is not that important, but that is a
serious problem with Python. you are always adviced to *never* mix tab
and space when indenting Python code. that is *evil*. we must consider
this as bug, and fix them all.

looks like all the Python code use 4 spaces to identation. could any
developers who wrote those code confirm that they set tab as 4 spaces
in their editor?

i will try to fix all the tabs by replacing them with 4 spaces, check
it carefully to make sure no error is introduced, and send in the
patch (for Python code only).

regards,
aq

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel