| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH] make domu_debug run-time option + fix int3 handl
On Mon, May 16, 2005 at 03:08:24PM -0700, Kip Macy wrote:
> "domu_debug" was mutually exclusive with crash_debug, which doesn't make sense
> to me. The other stub already had a #if 0 as a pre-processor guard around it.
> So
> the end effect with the patch is that domu_debug would be on by default and
> cdb
> could be enabled at compile-time. As I recall, there is no working
> functionality
> that this changes. I'll go back and look and recant if I am in error.
Unless I misread the patch (didn't apply it), you'd end up with unconditional
definitions of debugger_trap_fatal and debugger_trap_immediate?
I usually just toggle the #elif 0 to enable the kdb stubs, I don't see
how that would work now, without having to do more changes?
> I will make debugger_trap_entry call my code only if the domain flag is set,
> but
> right now this is the only debugger type that has a real debugger_trap_entry -
> so multiplexing seems a bit silly. There are hundreds of other places in the
> code where we could generalize for future extensibility.
Ok, fair enough. Put a comment on it then ;-)
christian
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home