WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] fix tool pygrub build on x64

To: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix tool pygrub build on x64
From: Jerone Young <jyoung5@xxxxxxxxxx>
Date: Mon, 16 May 2005 16:28:03 -0500
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 16 May 2005 21:28:55 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20050516211310.GA15474@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1116270934.4807.92.camel@thinkpad> <20050516211310.GA15474@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Ok,
        To better followup my findings you will see that size_t is of type
__kernel_size_t. On i386 in "asm-i386/posix_types.h" you have:
typedef unsigned int    __kernel_size_t;

Where as on x86-64 you in "asm-x86_64/posix_types.h" you have:

typedef unsigned long   __kernel_size_t;

I must have typed "unsigned int" by accident. Sorry. But the fix is
still valid.

Where as in 
On Mon, 2005-05-16 at 23:13 +0200, Vincent Hanquez wrote:
> On Mon, May 16, 2005 at 02:15:33PM -0500, Jerone Young wrote:
> > This fixes tool pygrub to build on x86-64 systems. Currently gcc is
> > saying there are incompatible pointer type passed into function
> > ext2fs_file_read. The address of variable n is used in ext2fs_file_read
> > which takes an "unsigned int *" as the 4th variable. "n" is currently
> > declared as an "size_t" which is an "int". This declares n as an
> > "unsigned int" instead of using type "size_t".
> 
> size_t is "unsigned long" not "int"
> 
-- 
Jerone Young
IBM Linux Technology Center
jyoung5@xxxxxxxxxx
512-838-1157 (T/L: 678-1157)


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel