RE: [Xen-devel] VMX check in /xen/arch/x86/domain.c is invalid onx86-64 (at least AMD)

["Jonathan S. Shapiro" <shap@xxxxxxxxxxx>]

On Thu, 2005-05-12 at 05:11 -0400, Jonathan S. Shapiro wrote:
> On Wed, 2005-05-11 at 22:28 -0700, Nakajima, Jun wrote:
> > Jerone Young wrote:
> > > if (!(c->flags & ECF_VMX_GUEST))
> > >         if ( ((c->cpu_ctxt.cs & 3) == 0) ||
> > >              ((c->cpu_ctxt.ss & 3) == 0) )
> > >                 return -EINVAL;
> > 
> > This c->flags has nothing to do with the machine architecture, but it's
> > just a software field for the domain builder to specify the type of the
> > domain (i.e. VMX or not, for example). The rflags is in
> > execution_context_t.
> 
> Then it *definitely* should not be named flags. Perhaps rename to
> domFlags?

Sorry. That was excessively terse.

The field should be renamed because the above misread is likely to be a
recurring issue for code maintenance.

shap


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel