Re: [Xen-devel] Unstableness in grant table block drivers

[Xiaofeng Ling <xiaofeng.ling@xxxxxxxxx>]

I found there is bug in the 2.4 vbd grant table code

===== xen-bk/linux-2.6.11-xen-sparse/drivers/xen/blkfront/blkfront.c 
1.53 vs edited =====
--- 1.53/linux-2.6.11-xen-sparse/drivers/xen/blkfront/blkfront.c 
2005-04-21 17:14:12 +08:00
+++ 
edited/xen-bk/linux-2.6.11-xen-sparse/drivers/xen/blkfront/blkfront.c 
    2005-05-12 09:15:38 +08:00
@@ -824,7 +824,7 @@
                         buffer_ma >> PAGE_SHIFT,
                         ( operation == BLKIF_OP_WRITE ? 1 : 0 ) );

-            blk_shadow[id].frame[req->nr_segments] =
+            blk_shadow[req->id].frame[req->nr_segments] =
                 buffer_ma >> PAGE_SHIFT;

             req->frame_and_sects[req->nr_segments] =


Christopher Clark wrote:
> Ryan
>
> Many thanks for taking the traces. I've located a bug in the block
> backend that may or may not be the required fix -- it's a move of a
> single line, see the patch below.
>
> c.
>
> Signed-off-by: Christopher Clark
>
> diff -Nru a/linux-2.6.11-xen-sparse/drivers/xen/blkback/blkback.c
> b/linux-2.6.11-xen-sparse/drivers/xen/blkback/blkback.c
> --- a/linux-2.6.11-xen-sparse/drivers/xen/blkback/blkback.c 2005-04-20
> 11:31:20 -07:00
> +++ b/linux-2.6.11-xen-sparse/drivers/xen/blkback/blkback.c 2005-04-20
> 11:31:20 -07:00
> @@ -516,11 +516,11 @@
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel