WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Increase size of sxpr parser input buffer

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] Increase size of sxpr parser input buffer
From: "Jonathan S. Shapiro" <shap@xxxxxxxxxxx>
Date: Sat, 07 May 2005 21:38:46 -0400
Delivery-date: Sun, 08 May 2005 02:32:32 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20050507171108.GD23932@xxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20050507171108.GD23932@xxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Sat, 2005-05-07 at 19:11 +0200, Jody Belka wrote:
> plain text document attachment (sxpr_parser.patch)
> Increase the size of the sxpr parser input buffer from 1024 characters, which
> isn't long enough to hold larger domain configurations (xfrd transmits the
> entire domain config sxpr as a single atom inside of another sxpr).

This seems like the wrong fix. The buffer size wasn't the problem. The
problem was the bad design assumption in xfrd.

It's almost always the wrong thing to insert a patch whose effect is to
mask a known problem.

shap


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>