WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [patch] explicitly defining memmove for x86_64

To: Scott Parish <srparish@xxxxxxxxxx>
Subject: Re: [Xen-devel] [patch] explicitly defining memmove for x86_64
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Sat, 07 May 2005 11:13:03 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sat, 07 May 2005 10:12:52 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: Your message of "Wed, 04 May 2005 23:06:46 -0000." <20050504230646.GB3247@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> Without the attached patch ubuntu's gcc (3.3.5) was complaining about
> the implicit declaration of __builtin_memmove. Extern'ing past that,
> the linker wouldn't resolve the same symbol.
> 
> This patch just does the same thing that is already done for x86_32.
> 
> signed-off-by: scott parish <srparish@xxxxxxxxxx>
> 
> sRp

Thanks. I checked in a version that always uses the implementation in
arch/x86/string.c. It's not worthwhile inlining since it's never used
anywhere performance critical (should probably remove the version in
x86_32/string.h as well).

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel