WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [patch] pagetable cleanups, next version

To: Gerd Knorr <kraxel@xxxxxxxxxxx>
Subject: Re: [Xen-devel] [patch] pagetable cleanups, next version
From: Chris Wright <chrisw@xxxxxxxx>
Date: Fri, 15 Apr 2005 10:20:54 -0700
Cc: Chris Wright <chrisw@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 15 Apr 2005 17:20:56 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20050415164654.GA9516@bytesex>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20050415125620.GA7531@bytesex> <20050415162338.GQ493@xxxxxxxxxxxxxxxxxxx> <20050415164654.GA9516@bytesex>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.6i
* Gerd Knorr (kraxel@xxxxxxxxxxx) wrote:
> There is the new l?e_has_changed() function which can be used to compare
> two page table entries.  It takes ptr's to two page table entries and a
> bitmask with the page flags it should care about.  The function will
> also deal with PAGE_MASK, so this is gone from the functions calling
> into l?e_has_changed().
> 
> In that particular function I also ditched the MATCH_ENTRY() macro which
> did something simliar to l?e_has_changed() in a less generic way.  That
> makes the code look even more different, although it _should_ be the
> same logic and it IMHO is also more readable.  I admit that I havn't
> tested shadow mode though ...
> 
> > Looks like create plus has changed is the new way?
> 
> Huh?  I lost you here ...

Sorry, that was my bad shorhand for l1e_create followed by l1e_has_changed.
Thanks for confirmation/explanation.

-chris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>