RE: [Xen-devel] [patch] pagetable cleanups

["Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>]

> > There's also no macros for creating L1E or L2E as 
> expressions -- only 
> > statements which assign them.  Perhaps this was 
> intentional?  It means 
> > that you end up declaring extra variables to hold essentially 
> > temporary values in a few places...
> 
> Yes, was intentionally.  I think that isn't bad, it makes the 
> code more readable.  And I think it actually is impossible to 
> return structs in C, you can only return a pointer to a 
> struct, which would't help for the "building entries as 
> expressions" case.

Returning structs is actually fine, at least on modern C
implementations.
Gcc seems to optimise for it OK.

Personally think having "a = foo(b,c)" is actually more readable than
"foo(&a,b,c)".

Ian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel