[Xen-devel] x86_64/page.h L1_DISALLOW_MASK, etc

In xen/include/asm-x86/x86_64/page.h, it appears the #defines for
L1_DISALLOW_MASK, L2_DISALLOW_MASK, etc. have the assignment backwards
in the conditional test.  The current code appears to be setting the NX
bit if the cpu does not have the NX feature, as opposed to if it does.

I have attached a patch of how I would change it to see if others agree.

Also, what exactly is being set when setting the 3 bits for the
L2_DISALLOW_MASK, L3_DISALLOW_MASK, and L4_DISALLOW_MASK definitions?

Karen

page.disallow.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] x86_64/page.h L1_DISALLOW_MASK, etc, Karen White <= Re: [Xen-devel] x86_64/page.h L1_DISALLOW_MASK, etc, Keir Fraser

Previous by Date:

Re: [Xen-devel] [bug?] xm sysrq == Internal Server Error, Mark Williamson

Next by Date:

[Xen-devel] [PATCH] add pae flag to xen/Rules.mk, Karen White

Previous by Thread:

[Xen-devel] [PATCH] add a 'tags' target for ctags, Rik van Riel

Next by Thread:

Re: [Xen-devel] x86_64/page.h L1_DISALLOW_MASK, etc, Keir Fraser

Indexes:

[Date] [Thread] [Top] [All Lists]