Re: [Xen-devel] [PATCH] tools top level makefile cleanup

[Adam Heath <doogie@xxxxxxxxxxxxx>]

On Wed, 23 Mar 2005, Christian Limpach wrote:

> On Tue, 22 Mar 2005 15:10:21 -0600, Jerone Young <jyoung5@xxxxxxxxxx> wrote:
> > I cleaned up the top level makefile in the tools directory. No major
> > changes. Except I have it so that ioemmu is compiled only with x86_32.
>
> I think the change below changes the behaviour:
>
> > +SUBDIRS :=
> > +SUBDIRS += check
> ...
> > -install:
> > -       $(MAKE) -C check
> > -       $(MAKE) -C libxutil install
> ...
> > +install:
> > +       @for subdir in $(SUBDIRS); do \
> > +               $(MAKE) -C $$subdir $@ || exit -1; \
> > +       done
>
> You're calling ``make -C check install'' while we want to call ``make
> -C check''.  See the comments in tools/check/Makefile why we want
> this...
> # Check this machine is OK for installing on.
> # DO NOT use this check from 'make install' in the parent
> # directory, as that target can be used to make an installable
> # copy rather than actually installing.
>
> At least you didn't try to go down the insane "try to make everything
> build in parallel" road, it might work for the tools but you need to
> be careful to make sure that targets which other targets depend on get
> built first.  None of the fancy Makefile tricks which other people
> have posted seem to take this into account :-(

==
install: check
        @whatever way people want to recurse

check:
        $(MAKE) -C check
# check is a real subdir, so we need to make it PHONY; otherwise, make assumes
# it's uptodate, and the command won't be run.
.PHONY: check
==

I originally didn't comment on this, as it wasn't my focus.  But yes, if you
are going to replace a set of rules, make certain they do the same thing after
as they did before.



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel