Re: [Xen-devel] [patch] include missing headers

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Tuesday 15 March 2005 13:27, Keir Fraser wrote:
> On 15 Mar 2005, at 18:25, Hollis Blanchard wrote:
> > sched.h uses test_and_clear_bit, so needs bitops.h.
> > softirq.h uses softirq_pending, so needs irq_cpustat.h.
> >
> > Signed-off-by: Hollis Blanchard <hollisb@xxxxxxxxxx>
>
> These headers are included indirectly already, or Xen wouldn't build.

Agreed. However they are not included indirectly in the PPC headers I'm 
working on, so Xen does not build.

Isn't it a good idea to directly include the headers you need?

-- 
Hollis Blanchard
IBM Linux Technology Center


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel