WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] list.h minor clean

To: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] list.h minor clean
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 25 Jan 2005 07:48:04 +0000
Cc: Xen Mailing List <xen-devel@xxxxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 25 Jan 2005 15:41:31 +0000
Envelope-to: xen+James.Bulpin@xxxxxxxxxxxx
In-reply-to: Your message of "Tue, 25 Jan 2005 16:13:41 +1100." <1106630022.19186.38.camel@xxxxxxxxxxxxxxxxxxxxx>
List-archive: <http://sourceforge.net/mailarchive/forum.php?forum=xen-devel>
List-help: <mailto:xen-devel-request@lists.sourceforge.net?subject=help>
List-id: List for Xen developers <xen-devel.lists.sourceforge.net>
List-post: <mailto:xen-devel@lists.sourceforge.net>
List-subscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=subscribe>
List-unsubscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=unsubscribe>
Sender: xen-devel-admin@xxxxxxxxxxxxxxxxxxxxx
> Hi all,
> 
>       When I added (the typesafe) list_for_each_entry() to Linux's list.h I
> considered just calling it list_for_each(), and replacing all the
> callers, but the size of the task defeated me.  Xen, however, is
> smaller.
> 
> You may think this patch sucks, but I had to try.  Boot tested.

I like it. I've always disliked the Linux use of list_entry() to get
the containing structure. I'll read through it a bit more carefully
and then check it in. Thanks!

I may keep the rename though -- some other arch developers want to
pull in or symlink to unmodified Linux source files, and they won;t
appreciate the name clash. :-)

> Rusty.
> PS.  I haven't seen a discussion on codingstyle: some of these are
> definitely not Linux-style...

I hate that the Linux style uses 8-space hard tabs. I could live with
it apart from that.

 -- Keir


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel

<Prev in Thread] Current Thread [Next in Thread>