WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [Patch] Always call blkdev_put when destroying a vbd in

To: Christian Limpach <Christian.Limpach@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [Patch] Always call blkdev_put when destroying a vbd in device backend
From: Adam Heath <doogie@xxxxxxxxxxxxx>
Date: Fri, 27 Aug 2004 21:18:57 -0500 (CDT)
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxxx>
Delivery-date: Sat, 28 Aug 2004 03:21:35 +0100
Envelope-to: steven.hand@xxxxxxxxxxxx
In-reply-to: <20040828000110.GI17300@xxxxxxxxxxxx>
List-archive: <http://sourceforge.net/mailarchive/forum.php?forum=xen-devel>
List-help: <mailto:xen-devel-request@lists.sourceforge.net?subject=help>
List-id: List for Xen developers <xen-devel.lists.sourceforge.net>
List-post: <mailto:xen-devel@lists.sourceforge.net>
List-subscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=subscribe>
List-unsubscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=unsubscribe>
References: <20040827163622.B18740@xxxxxxxxxxx> <20040828000110.GI17300@xxxxxxxxxxxx>
Sender: xen-devel-admin@xxxxxxxxxxxxxxxxxxxxx
On Sat, 28 Aug 2004, Christian Limpach wrote:

> On Fri, Aug 27, 2004 at 04:36:22PM -0700, Michael Vrable wrote:
> > The code for the block backend device in XenoLinux 2.6.8.1 doesn't call
> > blkdev_put on all code paths that can destroy a vbd.  Previously,
> > blkdev_put was only called from vbd_shrink.  I've added the call to
> > vbd_destroy and destroy_all_vbds.
> >
> > With the old code, the kernel running in domain-0 would believe the
> > devices exported to another domain to still be in use, even after the
> > other domain was shutdown.  (This was obvious when using LVM, since the
> > logical volumes were still listed as open, and a warning message was
> > printed when shutting down LVM.)  This patch should fix that.
>
> Thanks.  I've applied the patch.

That patch is a bit ugly.  Version checks scattered thruout the code is not
something Linus likes.

Better to make a macro that expands to nothing when not needed, and place it
in a header file.



-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel

<Prev in Thread] Current Thread [Next in Thread>