Re: [Xen-devel] Minor bugs in latest code drop

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

> I have a couple of minor bugs in the latest code (with nodev=y).
>  
> 1)       The arch/i386/Rules.mk specifies -Werror -, and a few modules
> have warnings (might be my gcc version [3.3.2].). E.G.
> "gcc -nostdinc -fno-builtin -fno-common -fno-strict-aliasing -O3
> -iwithprefix include -Wall -DMONITOR_BASE=0xFC500000
> -fomit-frame-pointer -I/home/barry/xen/xen/include -D__KERNEL__
> -Wno-pointer-arith -Wredundant-decls -m32 -march=i686 -DNDEBUG
> -DNO_DEVICES_IN_XEN -c schedule.c -o schedule.o
> schedule.c:666: warning: `process_timeout' defined but not used"
>  
> I fixed the problem by removing -Werror from Rules.mk

Send me the warnings and I'll check in fixes. I would like GCC 3.2.x
and 3.3.x to compile Xen with no warnings.

>       2)  in setup.c - with nodev=y, in my environment I have no modules
> that have any __init code in them. The do_initcalls routine doesn't work
> properly in this case, and tries to call the first one before checking
> that there are no more. I fixed the problem by moving the do_initcalls
> into the conditional code for handling devices. I am not sure why you
> are not seeing the same problem.

I'll fix this. Not sure why it didn't bite me!

 -- Keir


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel