This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] hvmloader: don't clear acpi_info after fi

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] hvmloader: don't clear acpi_info after filling in some fields
From: Xen patchbot-unstable <patchbot@xxxxxxx>
Date: Wed, 14 Sep 2011 18:55:09 +0100
Delivery-date: Wed, 14 Sep 2011 10:56:37 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1315905723 -3600
# Node ID ad958e87db79549165661d50b9b77526f22b0f03
# Parent  0312575dc35e4294eb50e365b2c10078914daca8
hvmloader: don't clear acpi_info after filling in some fields

In particular the madt_lapic0_addr and madt_csum_addr fields are
filled in while building the tables.

This fixes a bluescreen on shutdown with certain versions of Windows.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Reported-by: Christoph Egger <Christoph.Egger@xxxxxxx>
Tested-and-acked-by: Christoph Egger <Christoph.Egger@xxxxxxx>

diff -r 0312575dc35e -r ad958e87db79 tools/firmware/hvmloader/acpi/build.c
--- a/tools/firmware/hvmloader/acpi/build.c     Thu Sep 08 15:13:06 2011 +0100
+++ b/tools/firmware/hvmloader/acpi/build.c     Tue Sep 13 10:22:03 2011 +0100
@@ -277,6 +277,8 @@
     unsigned long        secondary_tables[16];
     int                  nr_secondaries, i;
+    memset(acpi_info, 0, sizeof(*acpi_info));
      * Fill in high-memory data structures, starting at @buf.
@@ -375,7 +377,6 @@
                  offsetof(struct acpi_20_rsdp, extended_checksum),
                  sizeof(struct acpi_20_rsdp));
-    memset(acpi_info, 0, sizeof(*acpi_info));
     acpi_info->com1_present = uart_exists(0x3f8);
     acpi_info->com2_present = uart_exists(0x2f8);
     acpi_info->lpt1_present = lpt_exists(0x378);

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] hvmloader: don't clear acpi_info after filling in some fields, Xen patchbot-unstable <=