This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-4.1-testing] xen: __hvm_pci_intx_assert should chec

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-4.1-testing] xen: __hvm_pci_intx_assert should check for gsis remapped onto pirqs
From: Xen patchbot-4.1-testing <patchbot@xxxxxxx>
Date: Thu, 01 Sep 2011 19:22:10 +0100
Delivery-date: Thu, 01 Sep 2011 11:22:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
# Date 1314801167 -3600
# Node ID 6239209bb560b4931d4d97456c82c1a5ca4bd10a
# Parent  50496ccde3c386b2bc34e290e61ae55fa9195d2d
xen: __hvm_pci_intx_assert should check for gsis remapped onto pirqs

If the isa irq corresponding to a particular gsi is disabled while the
gsi is enabled, __hvm_pci_intx_assert will always inject the gsi
through the violapic, even if the gsi has been remapped onto a pirq.
This patch makes sure that even in this case we inject the
notification appropriately.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
xen-unstable changeset:   23807:2297b90a6a7b
xen-unstable date:        Wed Aug 31 15:23:34 2011 +0100

diff -r 50496ccde3c3 -r 6239209bb560 xen/arch/x86/hvm/irq.c
--- a/xen/arch/x86/hvm/irq.c    Wed Aug 31 15:32:24 2011 +0100
+++ b/xen/arch/x86/hvm/irq.c    Wed Aug 31 15:32:47 2011 +0100
@@ -28,7 +28,7 @@
 #include <asm/hvm/support.h>
 /* Must be called with hvm_domain->irq_lock hold */
-static void assert_irq(struct domain *d, unsigned ioapic_gsi, unsigned pic_irq)
+static void assert_gsi(struct domain *d, unsigned ioapic_gsi)
     int pirq = domain_emuirq_to_pirq(d, ioapic_gsi);
     if ( hvm_domain_use_pirq(d, pirq) )
@@ -37,6 +37,11 @@
     vioapic_irq_positive_edge(d, ioapic_gsi);
+static void assert_irq(struct domain *d, unsigned ioapic_gsi, unsigned pic_irq)
+    assert_gsi(d, ioapic_gsi);
     vpic_irq_positive_edge(d, pic_irq);
@@ -61,7 +66,7 @@
     gsi = hvm_pci_intx_gsi(device, intx);
     if ( hvm_irq->gsi_assert_count[gsi]++ == 0 )
-        vioapic_irq_positive_edge(d, gsi);
+        assert_gsi(d, gsi);
     link    = hvm_pci_intx_link(device, intx);
     isa_irq = hvm_irq->pci_link.route[link];

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-4.1-testing] xen: __hvm_pci_intx_assert should check for gsis remapped onto pirqs, Xen patchbot-4 . 1-testing <=