This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-4.0-testing] libxc: obtain correct length of p2m du

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-4.0-testing] libxc: obtain correct length of p2m during core dumping
From: Xen patchbot-4.0-testing <patchbot@xxxxxxx>
Date: Tue, 31 May 2011 21:25:10 +0100
Delivery-date: Tue, 31 May 2011 13:25:47 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Markus Gross <gross@xxxxxxxxxxxxx>
# Date 1306571308 -3600
# Node ID 5768b9b19aaf85be21bb9e5673ca3bcb95178907
# Parent  3220df717f1098ed40dd3dd66edb6a13673750e7
libxc: obtain correct length of p2m during core dumping

while implementing core dumping functionality for the libxl driver
of libvirt, I discovered an issue with mapping pages of a pv guest.

After dumping the core of a pv guest the domain was not cleared up
properly and some pages were not unmapped. This issue is similar
to the one reported here:

In xc_domain_dumpcore_via_callback in the file xc_core.c the function
xc_core_arch_map_p2m is called to map P2M_FL_ENTRIES pages to the
variable p2m.
But to unmap the pages later, the dinfo->p2m_size has to be set
This was not done, instead a variable named p2m_size was set.
This way P2M_FL_ENTRIES was always zero and the pages were left

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
xen-unstable changeset:   23374:8bd7b5e98f2a
xen-unstable date:        Tue May 24 15:00:16 2011 +0100

diff -r 3220df717f10 -r 5768b9b19aaf tools/libxc/xc_core.c
--- a/tools/libxc/xc_core.c     Sat May 28 09:26:32 2011 +0100
+++ b/tools/libxc/xc_core.c     Sat May 28 09:28:28 2011 +0100
@@ -448,7 +448,6 @@
     int auto_translated_physmap;
     xen_pfn_t *p2m = NULL;
-    unsigned long p2m_size = 0;
     struct xen_dumpcore_p2m *p2m_array = NULL;
     uint64_t *pfn_array = NULL;
@@ -549,7 +548,7 @@
         sts = xc_core_arch_map_p2m(xc_handle, dinfo->guest_width, &info, 
-                                   &p2m, &p2m_size);
+                                   &p2m, &dinfo->p2m_size);
         if ( sts != 0 )
             goto out;

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-4.0-testing] libxc: obtain correct length of p2m during core dumping, Xen patchbot-4 . 0-testing <=