This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-4.1-testing] pv-grub: Fix for incorrect dom->p2m_ho

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-4.1-testing] pv-grub: Fix for incorrect dom->p2m_host[] list initialization
From: Xen patchbot-4.1-testing <patchbot@xxxxxxx>
Date: Thu, 28 Apr 2011 11:35:10 +0100
Delivery-date: Thu, 28 Apr 2011 03:35:19 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Daniel Kiper <dkiper@xxxxxxxxxxxx>
# Date 1303907441 -3600
# Node ID 88c46006b8035af73ba904901f45c3602d06be36
# Parent  7c7ef1b6f4e571a31f8e9e3be5c30d94a75fe7b2
pv-grub: Fix for incorrect dom->p2m_host[] list initialization

Introduction of Linux Kernel git commit
ceefccc93932b920a8ec6f35f596db05202a12fe (x86: default
deeply hidden bug in pv-grub. During kernel load stage dom->p2m_host[]
list has been incorrectly initialized.

At the beginning of kernel load stage dom->p2m_host[] list is
populated with current PFN->MFN layout. Later during memory allocation
(memory is allocated page by page in kexec_allocate()) page order is
changed to establish linear layout in new domain. It is done by
exchanging subsequent MFNs with newly allocated MFNs. dom->p2m_host[]
list is indexed by currently requested PFN (it is incremented from 0)
and PFN of newly allocated paged. If PFN of newly allocated page is
less than currently requested PFN then earlier allocated MFN is
overwritten which leads to domain crash later. This patch corrects
that issue. If PFN of newly allocated page is less then currently
requested PFN then relevant PFN/MFN pair is properly calculated and
usual exchange occurs later.

Signed-off-by: Daniel Kiper <dkiper@xxxxxxxxxxxx>
Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
xen-unstable changeset:   23249:83fe79c0225f
xen-unstable date:        Wed Apr 27 13:29:14 2011 +0100

diff -r 7c7ef1b6f4e5 -r 88c46006b803 stubdom/grub/kexec.c
--- a/stubdom/grub/kexec.c      Tue Apr 26 14:11:18 2011 +0100
+++ b/stubdom/grub/kexec.c      Wed Apr 27 13:30:41 2011 +0100
@@ -48,6 +48,7 @@
 static unsigned long *pages;
 static unsigned long *pages_mfns;
+static xen_pfn_t *pages_moved2pfns;
 static unsigned long allocated;
 int pin_table(xc_interface *xc_handle, unsigned int type, unsigned long mfn,
@@ -80,6 +81,7 @@
     pages = realloc(pages, new_allocated * sizeof(*pages));
     pages_mfns = realloc(pages_mfns, new_allocated * sizeof(*pages_mfns));
+    pages_moved2pfns = realloc(pages_moved2pfns, new_allocated * 
     for (i = allocated; i < new_allocated; i++) {
         /* Exchange old page of PFN i with a newly allocated page.  */
         xen_pfn_t old_mfn = dom->p2m_host[i];
@@ -91,6 +93,18 @@
         new_pfn = PHYS_PFN(to_phys(pages[i]));
         pages_mfns[i] = new_mfn = pfn_to_mfn(new_pfn);
+       /*
+        * If PFN of newly allocated page (new_pfn) is less then currently
+        * requested PFN (i) then look for relevant PFN/MFN pair. In this
+        * situation dom->p2m_host[new_pfn] no longer contains proper MFN
+        * because original page with new_pfn was moved earlier
+        * to different location.
+        */
+       for (; new_pfn < i; new_pfn = pages_moved2pfns[new_pfn]);
+       /* Store destination PFN of currently requested page. */
+       pages_moved2pfns[i] = new_pfn;
         /* Put old page at new PFN */
         dom->p2m_host[new_pfn] = old_mfn;

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-4.1-testing] pv-grub: Fix for incorrect dom->p2m_host[] list initialization, Xen patchbot-4 . 1-testing <=