This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-4.0-testing] amd-k8-mce: remove a stray break state

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-4.0-testing] amd-k8-mce: remove a stray break statement
From: Xen patchbot-4.0-testing <patchbot@xxxxxxx>
Date: Fri, 25 Feb 2011 18:45:08 +0000
Delivery-date: Fri, 25 Feb 2011 10:46:26 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir@xxxxxxx>
# Date 1298540183 0
# Node ID 3a1a7e071bb0a940bfbd38d9eddd067505b7a970
# Parent  36a94c8612500ee14fac864fee03f35fe3cbea9f
amd-k8-mce: remove a stray break statement

This was a leftover of converting from a switch to an if/else
somewhere between 3.4 and 4.0.

It also looks suspicious that MCEQUIRK_K7_BANK0 is not actually used
anywhere. Perhaps amd_k7_mcheck_init() and amd_k8_mcheck_init() were
intended to get (partially) folded?

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
xen-unstable changeset:   22947:598d1fc295b6
xen-unstable date:        Thu Feb 24 09:33:19 2011 +0000

diff -r 36a94c861250 -r 3a1a7e071bb0 xen/arch/x86/cpu/mcheck/amd_k8.c
--- a/xen/arch/x86/cpu/mcheck/amd_k8.c  Fri Feb 18 10:24:36 2011 +0000
+++ b/xen/arch/x86/cpu/mcheck/amd_k8.c  Thu Feb 24 09:36:23 2011 +0000
@@ -97,7 +97,6 @@
                        /* Enable error reporting of all errors */
                        wrmsrl(MSR_IA32_MC0_CTL + 4 * i, 0xffffffffffffffffULL);
                        wrmsrl(MSR_IA32_MC0_STATUS + 4 * i, 0x0ULL);
-                       break;

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-4.0-testing] amd-k8-mce: remove a stray break statement, Xen patchbot-4 . 0-testing <=