This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-4.0-testing] x86: Fix pirq teardown on domain destr

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-4.0-testing] x86: Fix pirq teardown on domain destruction.
From: "Xen patchbot-4.0-testing" <patchbot@xxxxxxx>
Date: Sat, 29 Jan 2011 04:25:14 -0800
Delivery-date: Sat, 29 Jan 2011 04:25:52 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Wei Gang <gang.wei@xxxxxxxxx>
# Date 1296032753 0
# Node ID 0b16e1d60871aaeb94ca1e8e83a41b54b4579f07
# Parent  aadbc956e0d7a4ecf5aff3b683e28abfd4a7f0e7
x86: Fix pirq teardown on domain destruction.

The privilege check in unmap_domain_pirq() fails since the teardown
completes in RCU (idle domain) context. We can remove the check since
it is covered in physdev_op() already, which is the only potentially
unprivileged caller.

Signed-off-by: Wei Gang <gang.wei@xxxxxxxxx>
xen-unstable changeset:   22816:e7f44fb4ecc3
xen-unstable date:        Wed Jan 26 08:54:12 2011 +0000
 xen/arch/x86/irq.c |    3 ---
 1 files changed, 3 deletions(-)

diff -r aadbc956e0d7 -r 0b16e1d60871 xen/arch/x86/irq.c
--- a/xen/arch/x86/irq.c        Wed Jan 26 09:04:36 2011 +0000
+++ b/xen/arch/x86/irq.c        Wed Jan 26 09:05:53 2011 +0000
@@ -1549,9 +1549,6 @@ int unmap_domain_pirq(struct domain *d, 
     if ( (pirq < 0) || (pirq >= d->nr_pirqs) )
         return -EINVAL;
-    if ( !IS_PRIV_FOR(current->domain, d) )
-        return -EINVAL;

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-4.0-testing] x86: Fix pirq teardown on domain destruction., Xen patchbot-4.0-testing <=