This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] x86: remove BUG_ON() from QUIRK_IOAPIC_*_

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] x86: remove BUG_ON() from QUIRK_IOAPIC_*_REGSEL handler
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 08 Dec 2010 13:50:21 -0800
Delivery-date: Wed, 08 Dec 2010 13:51:32 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir@xxxxxxx>
# Date 1291746724 0
# Node ID bfd13358b8bf3a6ca49702d773435a67f1ea5551
# Parent  d4b35162b3a11f7d9c28501192b7e231609e561d
x86: remove BUG_ON() from QUIRK_IOAPIC_*_REGSEL handler

Since (non-pvops, 32-bit only up to 2.6.27) Linux would report "BAD"
unconditionally on all SiS chipset versions (it only looks for a PCI
device at 0000:00:00.0 with SiS as the vendor), we must not crash if
the report on a 64-bit hypervisor doesn't match the #define (which is

While we could honor the quirk indication even on 64-bit, it doesn't
seem worthwhile, as there's no evidence that newer SiS chipsets
(supporting 64-bit CPUs) are actually affected.

This should also address bug 1687 (mis-reported, however, afaict).

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
 xen/arch/x86/platform_hypercall.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletion(-)

diff -r d4b35162b3a1 -r bfd13358b8bf xen/arch/x86/platform_hypercall.c
--- a/xen/arch/x86/platform_hypercall.c Tue Dec 07 18:30:19 2010 +0000
+++ b/xen/arch/x86/platform_hypercall.c Tue Dec 07 18:32:04 2010 +0000
@@ -198,7 +198,10 @@ ret_t do_platform_op(XEN_GUEST_HANDLE(xe
             dprintk(XENLOG_INFO, "Domain 0 says that IO-APIC REGSEL is %s\n",
                     sis_apic_bug ? "bad" : "good");
-            BUG_ON(sis_apic_bug != (quirk_id == QUIRK_IOAPIC_BAD_REGSEL));
+            if ( sis_apic_bug != (quirk_id == QUIRK_IOAPIC_BAD_REGSEL) )
+                dprintk(XENLOG_WARNING,
+                        "Domain 0 thinks that IO-APIC REGSEL is %s\n",
+                        sis_apic_bug ? "good" : "bad");

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] x86: remove BUG_ON() from QUIRK_IOAPIC_*_REGSEL handler, Xen patchbot-unstable <=